[WIP] avoid to_region_vid ICE during constraint conversion#58839
Closed
pnkfelix wants to merge 2 commits intorust-lang:masterfrom
Closed
[WIP] avoid to_region_vid ICE during constraint conversion#58839pnkfelix wants to merge 2 commits intorust-lang:masterfrom
pnkfelix wants to merge 2 commits intorust-lang:masterfrom
Conversation
…n_vid calls. (required slight revision to to_region_vid to return Result.)
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 88801bf has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
@bors r- this does not appear to fully fix the problem. See #57464 (comment) |
bors
added
S-waiting-on-author
Contributor
Author
|
@matthewjasper That's unfortunate. What do you think about landing this anyway? I'm removing "fix" from the description. |
Contributor
Author
Contributor
|
I'm not sure, landing a partial fix that makes the code more complicated doesn't seem like such a great idea. |
pnkfelix
changed the title
Contributor
Author
|
I'm going to close this and see if I can attack the root problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cc #57464